Fix intersphinx_registry API break #12625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscheltienne
requested review from
larsoner,
drammock,
agramfort and
dengemann
as code owners
|
Sorry about the breakage. |
|
I've open Quansight-Labs/intersphinx_registry#9 for major announcement, and the version scheme is Major.YYMM.DD now if there is a (planed) API breakage I'll at lest bump major. If the breakage was not planned I'll yank the package and publish a new version. So you should be able to just just pin to 0.x.y. |
Carreau
approved these changes
May 27, 2024
|
@Carreau No problem, let's just avoid future breakage when possible :) |
mscheltienne
commented
May 27, 2024
| "intersphinx_registry", | ||
| "intersphinx_registry>=0.2405.27", |
There was a problem hiding this comment.
@Carreau I added this pin, so let's keep this version schema if possible :) Thanks for the replies!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. Quansight-Labs/intersphinx_registry@9aa7ec5
Reported upstream on commit comments to avoid API breaks on keyword-only arguments. I'm not pinning the version here as I'm not confident the version schema in
intersphinx_registrywill not change again.