-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EpochsTFR.add_channels()
#12616
Fix EpochsTFR.add_channels()
#12616
Conversation
3786fda
to
81ce0ad
Compare
Co-authored-by: Richard Höchenberger <[email protected]>
Thanks @cbrnr ! |
@cbrnr or @hoechenberger can you backport? |
Sorry, I don't really have time to go through this process, but please see #12623. |
@meeseeksdev backport to maint/1.7 |
@drammock the next time we want to backport we should try using the |
(Though I see it was too late here since this was merged a while ago!) |
...and already had that label :) though I guess I could have tried removing and re-adding the label, is that expected to work? regardless: this was the backport candidate that spurred the discussion that led to trying the bot, so I wanted to get it open quickly before I forgot about it (again) |
…`) (#12635) Co-authored-by: Clemens Brunner <[email protected]>
EpochsTFR.add_channels()
is currently broken, since it adds the objects in the wrong dimension (0, but should be 1). I think this should be backported if possible.