-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jinja2
and pooch
from sys_info
#12411
Conversation
jinja2
and pooch
from sys_info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. I think in principle maybe we could want all core dep versions listed somewhere, but in practice over the many years we've had this I don't think these have ever been useful to have reported. So I'm okay with removing them in favor of trimming things down a bit. But @drammock you had suggested possibly moving them rather than removing them so I'll let you look before merge
I'm also in favor of trimming down the output to things that will be relevant for us. It is unlikely that a bug is caused by pooch or jinja2 at the end of the day. Of course, we already have a |
Works for me and might satisfy @drammock's desire to keep them somewhere (he had suggested |
including under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the other required packages to a new section called "Infrastructure". Well, all but lazy_loader
, which doesn't have a version attribute.
pushed a commit to hopefully fix Circle, which seems to have been broken by docdict changes in #12195 cc @withmywoessner; see 43094a7; I think the only necessary changes were the ones relating to blank lines, but I took the opportunity to clean up the formatting a bit too |
reported the missing lazy_loader version upstream: scientific-python/lazy-loader#96 |
pip-pre failure is being tracked in #12413 |
Thanks @cbrnr ! |
Fixes #12387.