fix % in to f String #12405
Closed
fix % in to f String #12405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aditya3425-Fst
requested review from
larsoner,
wmvanvliet,
drammock,
dengemann,
adam2392,
mscheltienne,
alexrockhill,
agramfort,
hoechenberger,
jasmainak,
cbrnr,
rob-luke and
sappelhoff
as code owners
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
|
Thanks for taking a stab! There are several things that should be addressed:
|
mscheltienne
reviewed
Feb 5, 2024
Comment on lines
+269
to
+270
| # "Invalid parameter %s for estimator %s. " | ||
| f"Invalid parameter{name}for estimator{self}" |
There was a problem hiding this comment.
Suggested change
| # "Invalid parameter %s for estimator %s. " | |
| f"Invalid parameter{name}for estimator{self}" | |
| f"Invalid parameter {name} for estimator {self}. " |
Comment on lines
+197
to
+198
| # " %s with constructor %s doesn't " | ||
| f"{cls} with constructor {init_signature} doesn't follow this convention." |
There was a problem hiding this comment.
Suggested change
| # " %s with constructor %s doesn't " | |
| f"{cls} with constructor {init_signature} doesn't follow this convention." | |
| f" {cls} with constructor {init_signature} doesn't follow this convention." |
There was a problem hiding this comment.
There's also 2 spaces after "doesn't"
There was a problem hiding this comment.
fixed in the suggested change.
Comment on lines
+102
to
+103
| # warn("SVD error (%s), attempting to use GESVD instead of GESDD" % (exp,)) | ||
| warn(f"SVD error ({exp}), attempting to use GESVD instend of GESDD") |
There was a problem hiding this comment.
Suggested change
| # warn("SVD error (%s), attempting to use GESVD instead of GESDD" % (exp,)) | |
| warn(f"SVD error ({exp}), attempting to use GESVD instend of GESDD") | |
| warn(f"SVD error ({exp}), attempting to use GESVD instend of GESDD") |
Comment on lines
+280
to
+281
| # "Invalid parameter %s for estimator %s. " | ||
| f"Invalid parameter {key}for estimator{self.__class__.__name__} for estimator" |
There was a problem hiding this comment.
Suggested change
| # "Invalid parameter %s for estimator %s. " | |
| f"Invalid parameter {key}for estimator{self.__class__.__name__} for estimator" | |
| f"Invalid parameter {key} for estimator {self.__class__.__name__}. " |
Comment on lines
+293
to
+294
| # return "%s(%s)" % (class_name, self.__class__.__name__) | ||
| return f"{class_name}({self.__class__.__name__})" |
There was a problem hiding this comment.
Suggested change
| # return "%s(%s)" % (class_name, self.__class__.__name__) | |
| return f"{class_name}({self.__class__.__name__})" | |
| return f"{class_name}({params.read().strip()})" |
Comment on lines
+664
to
+665
| # msg = "Coil too close (dist = %g mm)" % (min_dist * 1000,) | ||
| msg = f"coil too close (dist = {(min_dist * 1000,)}mm)" |
There was a problem hiding this comment.
This one does not remove the trailing zeroes as %g does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12360
Summary:
This pull request addresses the conversion of "%" symbols into f-strings for improved readability and maintainability.
Changes Made:
Replaced "%" formatting with f-strings for string interpolation.
Updated relevant code blocks to adhere to the Python 3.6 and later syntax.
Benefits:
Enhanced code clarity: f-strings provide a more concise and readable syntax for string formatting.
Improved maintainability: The use of f-strings aligns with modern Python practices, making the codebase more up-to-date.
Testing:
Ensured that the changes do not introduce any functional issues.
Conducted thorough testing to validate the correctness of the converted f-strings.
Additional Notes:
No changes to the logic or functionality of the code, only a syntactic enhancement.
Compatible with Python 3.6 and later versions.
Please review the changes, and feel free to provide feedback or ask for further clarification if needed.