-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minimum/maximum value of the all-positive/negative data #12383
Merged
Merged
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
12fb2a8
Add min/max peak detect
withmywoessner a051beb
Merge branch 'main' of https://github.com/mne-tools/mne-python into d…
withmywoessner 8d24469
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7fcca17
Add sugestion api and tests
withmywoessner 40db187
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 052dcc6
Fix strings
withmywoessner a1e42ed
Merge branch 'detect_min_max' of https://github.com/withmywoessner/mn…
withmywoessner 9b042c4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e0b280e
changelog
withmywoessner 89a7dbf
Merge branch 'detect_min_max' of https://github.com/withmywoessner/mn…
withmywoessner 45e1ed6
Apply suggestions from code review
withmywoessner e329710
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confused; this doesn't match the API in the PR description (as was discussed in #12381)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that! I didn't push my changes yet.