-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Support TD data #11064
base: main
Are you sure you want to change the base?
ENH: Support TD data #11064
Changes from all commits
3f875d3
cc92adc
0d2fe87
21ecb90
4491064
dbdcebc
80de954
32c5496
a35822a
c2c217c
ac52bc0
da275f1
3986b96
ce8b3af
1244add
3944254
967dddd
e97367d
4b963cd
15e2878
d26ff8a
f84fe27
50f3064
495bdf7
a076e23
698d2a6
d3b75ab
b1cf310
0c4f886
34c36f5
b5e9967
34dffbf
d62dbb1
880356e
4f0e8e6
a5c97b8
fba1ffa
9f4234d
b3b3f2e
9723621
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -352,5 +352,6 @@ Yousra Bekhti <[email protected]> Yoursa BEKHTI <[email protected] | |
Yousra Bekhti <[email protected]> Yoursa BEKHTI <[email protected]> | ||
Yousra Bekhti <[email protected]> Yousra BEKHTI <[email protected]> | ||
Yousra Bekhti <[email protected]> yousrabk <[email protected]> | ||
Zahra M. Aghajan <[email protected]> Zahra M. Aghajan <[email protected]> | ||
Zhi Zhang <[email protected]> ZHANG Zhi <[email protected]> | ||
Zhi Zhang <[email protected]> ZHANG Zhi <[email protected]> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Added basic support for TD fNIRS data, by :newcontrib:`Zahra Aghajan`, :newcontrib:`Julien Dubois`, :newcontrib:`John Griffiths`, `Robert Luke`_, and `Eric Larson`_. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,8 @@ | |
fnirs_fd_ac_amplitude="k", | ||
fnirs_fd_phase="k", | ||
fnirs_od="k", | ||
fnirs_td_gated_amplitude="k", | ||
fnirs_td_moments_amplitude="k", | ||
csd="k", | ||
whitened="k", | ||
gsr="#666633", | ||
|
@@ -60,6 +62,8 @@ | |
fnirs_fd_ac_amplitude="V", | ||
fnirs_fd_phase="rad", | ||
fnirs_od="V", | ||
fnirs_td_gated_amplitude="M", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. these are photon counts, should they be "AU"? |
||
fnirs_td_moments_amplitude="M", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is a bit weird, the dataType
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ahhh... in this case we probably need to update the FIF "coil type" constants first since these are really sensing/detecting different sorts of data. Like we'll probably need:
or similar |
||
csd="V/m²", | ||
whitened="Z", | ||
gsr="S", | ||
|
@@ -88,6 +92,8 @@ | |
fnirs_fd_ac_amplitude="V", | ||
fnirs_fd_phase="rad", | ||
fnirs_od="V", | ||
fnirs_td_gated_amplitude="µM", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. update |
||
fnirs_td_moments_amplitude="µM", | ||
csd="mV/m²", | ||
whitened="Z", | ||
gsr="S", | ||
|
@@ -117,6 +123,8 @@ | |
fnirs_fd_ac_amplitude=1.0, | ||
fnirs_fd_phase=1.0, | ||
fnirs_od=1.0, | ||
fnirs_td_gated_amplitude=1e6, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I imagine this should be 1.0; same for |
||
fnirs_td_moments_amplitude=1e6, | ||
csd=1e3, | ||
whitened=1.0, | ||
gsr=1.0, | ||
|
@@ -151,6 +159,8 @@ | |
fnirs_fd_ac_amplitude=2e-2, | ||
fnirs_fd_phase=2e-1, | ||
fnirs_od=2e-2, | ||
fnirs_td_gated_amplitude=1.0, | ||
fnirs_td_moments_amplitude=1.0, | ||
csd=200e-4, | ||
dipole=1e-7, | ||
gof=1e2, | ||
|
@@ -206,6 +216,8 @@ | |
fnirs_fd_phase="fNIRS (FD phase)", | ||
fnirs_od="fNIRS (OD)", | ||
hbr="Deoxyhemoglobin", | ||
fnirs_td_gated_amplitude="fNIRS (TD amplitude)", | ||
fnirs_td_moments_amplitude="fNIRS (TD moment)", | ||
gof="Goodness of fit", | ||
csd="Current source density", | ||
stim="Stimulus", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JohnGriffiths @julien-dubois-k @Zahra-M-Aghajan let me know if you want a different URL to link from your name in the changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grifflab.com is perfect, thanks