Handle no-free strings properly. #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the `ruby` repo to include commits related to handling Strings with the `STR_NOFREE` flag.
This will help detecting dangling pointers earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
rubyrepo to include commits related to handling Strings with theSTR_NOFREEflag.The
rubyrepo also includes a change that forwardsrb_str_tmp_frozen_no_embed_acquiretorb_str_tmp_frozen_acquirebecause we don't need to workaround page locking when using MMTk.We also apply
-DMMTK_WB_ASSERT_VOwhen running CI tests. That will help us detect "destination is not MMTk object" bugs earlier at the time when the field is written to.