Push pinning roots #142
Merged
Push pinning roots #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinsoon
reviewed
Mar 19, 2024
mmtk/src/scanning.rs
Outdated
| @@ -189,6 +198,80 @@ impl Scanning<JuliaVM> for VMScanning { | |||
| } | |||
| } | |||
|
|
|||
| pub unsafe fn mmtk_scan_gcstack_roots<EV: EdgeVisitor<JuliaVMEdge>>( | |||
There was a problem hiding this comment.
This function looks very similar to the old mmtk_scan_gcstack. How is it different? Can you reduce duplicated code between those two functions?
There was a problem hiding this comment.
The main difference is that mmtk_scan_gcstack uses a single closure (as it's called when scanning objects) and mmtk_scan_gcstack_roots uses two closures (one for transitively pinned roots, and another for pinning roots). I tried using a single function, but I didn't find any way to call it with a single closure when scanning objects - if I try passing a single closure as both arguments, the rust compiler complains about having two mutable references of the closure.
Maybe I found a way. Will push it.
qinsoon
added a commit
to qinsoon/mmtk-julia
that referenced
this pull request
Nov 7, 2024
qinsoon
added a commit
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting processing roots in the shadow stack that are not transitively pinned (only the root object is pinned), and therefore should enable moving more objects.
NB: Should be merged with mmtk/julia#43.