Remove env_var and command_line from options #1240
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove env_var and command_line because they can all be set in both ways. Also renamed functions that set options by name, and removed "convenient methods" in MMTKBuilder and memory_manager.
Require T in MMTKOption<T> to implemnt FromStr because we use parse::<T>() anyway. Move Default out of macro. Update comments.
wks
force-pushed
the
fix/remove-envvar-cmdline
branch
from
8004a10 to
8941384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
from_env_varandfrom_command_linefromMMTkOptionbecause now all options can be set in both ways.Replaced
Options::set_from_command_lineandOptions::set_from_env_varwith a singleOptions::set_by_string.Moved several methods of
Optionsout of theoptions!macro if they don't need to be generated via macro expansion. Now only two methods are generated by the macro.set_by_string_inner: Requires matching field names against user-provided strings.new: Initializing fields using default values.In order to replicate the behavior that
Options::read_env_var_settingssilently ignores unrecognized option keys inMMTK_*environment variables, we introduced an error typeSetOptionByStringErrorwhichOptions::set_by_string_innerreturns so thatOptions::read_env_var_settingsandOptions::bulk_set_by_stringcan behave differently when encountering invalid keys.