Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GC: MMTk tag to Julia's banner when building with MMTk #72

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

udesou
Copy link

@udesou udesou commented Nov 26, 2024

Just added a piece of text when starting Julia so we know it's been built with MMTk.

@qinsoon
Copy link
Member

qinsoon commented Nov 26, 2024

MMTk provides its version info: https://docs.rs/mmtk/latest/mmtk/build_info/index.html. You probably want to include it in the banner or in the Julia's version.

This is what we do for OpenJDK:
mmtk/openjdk@80f3969
mmtk/mmtk-openjdk@688791e

@udesou Let me know if you want to do it in this PR or not. I will review the PR if you plan to do this change now.

@udesou
Copy link
Author

udesou commented Nov 26, 2024

MMTk provides its version info: https://docs.rs/mmtk/latest/mmtk/build_info/index.html. You probably want to include it in the banner or in the Julia's version.

This is what we do for OpenJDK: mmtk/openjdk@80f3969 mmtk/mmtk-openjdk@688791e

@udesou Let me know if you want to do it in this PR or not. I will review the PR if you plan to do this change now.

I'll try to use that and do something similar to what we do for OpenJDK then

@udesou udesou merged commit 5cacfa4 into mmtk:dev Nov 26, 2024
3 checks passed
qinsoon pushed a commit to mmtk/mmtk-julia that referenced this pull request Nov 27, 2024
Merge with mmtk/julia#72.

Should add info to Julia's banner about the version of MMTk used in the
build such as:

```
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.12.0-DEV.955 (2024-11-26)
 _/ |\__'_|_|_|\__'_|  |  adding-tag-to-banner/0ccc307863* (fork: 101 commits, 134 days)
|__/                   |  Built with MMTk Julia 0.1.0 (a775934-dirty), using MMTk 0.27.0 (de10fa4, DEFAULT, IMMIX_NON_MOVING, IMMIX_SMALLER_BLOCK, OBJECT_PINNING, VM_SPACE)
```
udesou added a commit that referenced this pull request Nov 29, 2024
* Adding GC: MMTk tag to banner when running with MMTk

* Getting info about MMTk build and printing it out

* Fixing whitespace
udesou added a commit that referenced this pull request Dec 2, 2024
* Adding GC: MMTk tag to banner when running with MMTk

* Getting info about MMTk build and printing it out

* Fixing whitespace
udesou added a commit that referenced this pull request Dec 3, 2024
* Adding GC: MMTk tag to banner when running with MMTk

* Getting info about MMTk build and printing it out

* Fixing whitespace
udesou added a commit to udesou/mmtk-julia that referenced this pull request Dec 4, 2024
…#193)

Merge with mmtk/julia#72.

Should add info to Julia's banner about the version of MMTk used in the
build such as:

```
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.12.0-DEV.955 (2024-11-26)
 _/ |\__'_|_|_|\__'_|  |  adding-tag-to-banner/0ccc307863* (fork: 101 commits, 134 days)
|__/                   |  Built with MMTk Julia 0.1.0 (a775934-dirty), using MMTk 0.27.0 (de10fa4, DEFAULT, IMMIX_NON_MOVING, IMMIX_SMALLER_BLOCK, OBJECT_PINNING, VM_SPACE)
```
udesou added a commit that referenced this pull request Dec 9, 2024
* Adding GC: MMTk tag to banner when running with MMTk

* Getting info about MMTk build and printing it out

* Fixing whitespace
udesou added a commit that referenced this pull request Dec 9, 2024
* Adding GC: MMTk tag to banner when running with MMTk

* Getting info about MMTk build and printing it out

* Fixing whitespace
udesou added a commit that referenced this pull request Dec 12, 2024
* Adding GC: MMTk tag to banner when running with MMTk

* Getting info about MMTk build and printing it out

* Fixing whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants