Avoid leaving cloudflared orphan process (#6)

mmiranda · Nov 29, 2021 · 3503c19 · 3503c19
1 parent 014e7b5
commit 3503c19
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/cfdtunnel/cfdtunnel.go b/cfdtunnel/cfdtunnel.go
@@ -91,15 +91,15 @@ func commandKill(cmd *exec.Cmd) {
 func (args Arguments) runSubCommand() {
 	log.Debugf("Running subcommand: %v", args.Command)
 	if !checkSubCommandExists(args.Command) {
-		os.Exit(1)
+		return
 	}
 
 	output, err := exec.Command(args.Command, args.Args...).CombinedOutput()
 
 	fmt.Println(string(output))
 
 	if err != nil {
-		log.Fatalf("An error occurred trying to run the command %v: %v", args.Command, err)
+		log.Errorf("An error occurred trying to run the command %v: %v", args.Command, err)
 	}
 
 }

diff --git a/cfdtunnel/cfdtunnel_test.go b/cfdtunnel/cfdtunnel_test.go
@@ -192,8 +192,8 @@ func TestRunSubCommandMissing(t *testing.T) {
 
 	// Cast the error as *exec.ExitError and compare the result
 	e, ok := err.(*exec.ExitError)
-	assert.True(t, ok)
-	assert.Equal(t, "exit status 1", e.Error())
+	assert.False(t, ok)
+	assert.Nil(t, e)
 
 }