Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End time can be before start time #31

Open
amythetester opened this issue Feb 1, 2023 · 1 comment
Open

End time can be before start time #31

amythetester opened this issue Feb 1, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@amythetester
Copy link
Collaborator

User is able to enter an earlier end time than the start time

@amythetester amythetester added the bug Something isn't working label Feb 1, 2023
@mmcknett
Copy link
Owner

mmcknett commented Feb 3, 2023

Good find. End time before start time should show a validation error and inhibit the submit button.

I don't think there would be any good reason to preserve this behavior. If for some reason users need a "negative time span" feature, it should probably be thought about independently with a different storage mechanism. Any other strange date-related corner cases, such as logging at 1:30am on "fall back" day or logging an event that crossed time-zones, would be better handled by handling time zones explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants