chore: avoid clippy errors

- Allow `elided-named-lifetimes` lint warning until a final fix. - Elide explicit lifetimes pointed out by clippy. Signed-off-by: Miguel Martín <[email protected]>
mmartinv · Nov 29, 2024 · 4e54988 · 4e54988
1 parent 69159fa
commit 4e54988
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 21 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/client-linuxapp/src/main.rs b/client-linuxapp/src/main.rs
@@ -1231,7 +1231,7 @@ async fn main() -> Result<()> {
         Command::new("systemctl")
             .arg("reboot")
             .spawn()
-            .expect("Reboot failed");
+            .expect("Reboot failed").wait()?;
     }
     Ok(())
 }
diff --git a/client-linuxapp/src/serviceinfo.rs b/client-linuxapp/src/serviceinfo.rs
@@ -108,6 +108,7 @@ fn create_user_with_password(user: &str, password: &str) -> Result<()> {
     log::info!("Checking for password encryption");
     if !is_password_encrypted(password) {
         log::info!("Encrypting password");
+        #[allow(clippy::zombie_processes)]
         let echo = Command::new("echo")
             .arg(password)
             .stdout(Stdio::piped())

diff --git a/data-formats/Cargo.toml b/data-formats/Cargo.toml
@@ -20,7 +20,7 @@ thiserror = "1"
 aws-nitro-enclaves-cose = { path = "../external/aws-nitro-enclaves-cose"}
 uuid = "1.3"
 num-traits = "0.2"
-num-derive = "0.3"
+num-derive = "0.4"
 paste = "1.0"
 pem = "3.0"
 tss-esapi = { version = "7.4", features = ["generate-bindings"] }

diff --git a/data-formats/src/constants/serviceinfo_names.rs b/data-formats/src/constants/serviceinfo_names.rs
@@ -6,7 +6,7 @@ impl<'de> serde::Deserialize<'de> for ServiceInfoModule {
         D: serde::de::Deserializer<'de>,
     {
         struct SIMVisitor;
-        impl<'de> serde::de::Visitor<'de> for SIMVisitor {
+        impl serde::de::Visitor<'_> for SIMVisitor {
             type Value = ServiceInfoModule;
 
             fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result {

diff --git a/data-formats/src/ownershipvoucher.rs b/data-formats/src/ownershipvoucher.rs
@@ -327,6 +327,7 @@ impl OwnershipVoucher {
 }
 
 impl<'a> OwnershipVoucher {
+    #[allow(elided_named_lifetimes)]
     pub fn iter_entries(&'a self) -> Result<EntryIter> {
         Ok(EntryIter {
             voucher: self,
@@ -347,7 +348,7 @@ pub struct EntryIter<'a> {
     last_pubkey: PublicKey,
 }
 
-impl<'a> Iterator for EntryIter<'a> {
+impl Iterator for EntryIter<'_> {
     type Item = Result<OwnershipVoucherEntryPayload>;
 
     fn next(&mut self) -> Option<Self::Item> {
@@ -378,7 +379,7 @@ impl<'a> Iterator for EntryIter<'a> {
     }
 }
 
-impl<'a> EntryIter<'a> {
+impl EntryIter<'_> {
     fn process_element(
         &mut self,
         entry: OwnershipVoucherEntry,

diff --git a/data-formats/src/types.rs b/data-formats/src/types.rs
@@ -390,7 +390,7 @@ impl<'de> Deserialize<'de> for IPAddress {
     {
         struct IPAddressVisitor;
 
-        impl<'de> serde::de::Visitor<'de> for IPAddressVisitor {
+        impl serde::de::Visitor<'_> for IPAddressVisitor {
             type Value = IPAddress;
 
             fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result {
@@ -1304,7 +1304,7 @@ impl<'de> Deserialize<'de> for KexSuite {
     {
         struct KexSuiteVisitor;
 
-        impl<'de> serde::de::Visitor<'de> for KexSuiteVisitor {
+        impl serde::de::Visitor<'_> for KexSuiteVisitor {
             type Value = KexSuite;
 
             fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result {
@@ -1964,7 +1964,7 @@ impl<'de> Deserialize<'de> for RemoteTransport {
     {
         struct RemoteTransportVisitor;
 
-        impl<'de> serde::de::Visitor<'de> for RemoteTransportVisitor {
+        impl serde::de::Visitor<'_> for RemoteTransportVisitor {
             type Value = RemoteTransport;
 
             fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result {