Add decimals keyword to gps text + move RAW keyword check #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to include this in Shotcut 24.10 release due by end-of-month even though it will not be tested? |
|
Yes, I can do more tests myself on the nightly to be safe, locally it was all good going through most of the keywords with a random file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-added decimals keyword to all numeric keywords: #gps_speed decimals 5# km/h
-refactored the code around the RAW keyword to avoid all those duplicated snprintf
Requested here:
https://forum.shotcut.org/t/about-gpstext-altitude/45566
https://forum.shotcut.org/t/hello-again-gps-dist/43313