Fix [Job Artifacts] same artifact opens for all artifacts on Show Det…

…ails click (#3009)
mlrun · Jan 13, 2025 · b24d472 · b24d472
1 parent 3c5f22b
commit b24d472
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 21 deletions.
diff --git a/src/components/DetailsArtifacts/detailsArtifacts.util.js b/src/components/DetailsArtifacts/detailsArtifacts.util.js
@@ -76,10 +76,11 @@ export const generateArtifactsTabContent = (
 ) => {
   const handleOpenArtifactPopUp = artifact => {
     const artifactData = {
+      kind: artifact.kind,
       project: artifact.project || params.projectName,
-      name: artifact.db_key || artifact.key,
-      iter: artifact.iter,
-      tree: artifact.tree,
+      key: artifact.db_key || artifact.key,
+      iteration: artifact.iter,
+      uid: artifact.tree,
       tag: artifact.tag
     }
 

diff --git a/src/elements/DetailsPopUp/ArtifactPopUp/ArtifactPopUp.js b/src/elements/DetailsPopUp/ArtifactPopUp/ArtifactPopUp.js
@@ -40,7 +40,7 @@ import {
 } from '../../../components/ModelsPage/Models/models.util'
 
 import { fetchDataSets, fetchFiles, fetchModels } from '../../../reducers/artifactsReducer'
-import { ARTIFACTS_TAB, DATASETS_TAB, FILES_TAB, MODELS_TAB } from '../../../constants'
+import { DATASETS_TAB, FILES_TAB, MODEL_TYPE, MODELS_TAB } from '../../../constants'
 import { toggleYaml } from '../../../reducers/appReducer'
 
 const ArtifactPopUp = ({ artifactData, isOpen, onResolve }) => {
@@ -58,19 +58,19 @@ const ArtifactPopUp = ({ artifactData, isOpen, onResolve }) => {
           pageData: generateDatasetPageData(selectedArtifact, viewMode, {}, true),
           fetchArtifact: fetchDataSets
         }
-      : artifactData.kind === ARTIFACTS_TAB
+      : artifactData.kind === MODEL_TYPE
         ? {
-            type: FILES_TAB,
-            generateActionsMenu: generateFileActionsMenu,
-            pageData: generateFilePageData(viewMode),
-            fetchArtifact: fetchFiles
-          }
-        : {
             type: MODELS_TAB,
             generateActionsMenu: generateModelActionsMenu,
             pageData: generateModelPageData(selectedArtifact, viewMode),
             fetchArtifact: fetchModels
           }
+        : {
+            type: FILES_TAB,
+            generateActionsMenu: generateFileActionsMenu,
+            pageData: generateFilePageData(viewMode),
+            fetchArtifact: fetchFiles
+          }
   }, [selectedArtifact, artifactData.kind, viewMode])
 
   const toggleConvertedYaml = useCallback(
@@ -122,16 +122,7 @@ const ArtifactPopUp = ({ artifactData, isOpen, onResolve }) => {
 
         onResolve()
       })
-  }, [
-    artifactContext,
-    dispatch,
-    onResolve,
-    artifactData.iteration,
-    artifactData.key,
-    artifactData.project,
-    artifactData.tag,
-    artifactData.uid
-  ])
+  }, [artifactData, artifactContext, dispatch, onResolve])
 
   const actionsMenu = useMemo(
     () => fileMin =>