Fix [Artifacts] add partition-by if Tag filter is set to "all" (#3042)

mlrun · Jan 21, 2025 · 985bde8 · 985bde8
1 parent 0d68d84
commit 985bde8
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 8 deletions.
diff --git a/src/common/HistoryBackLink/historyBackLink.scss b/src/common/HistoryBackLink/historyBackLink.scss
@@ -24,5 +24,9 @@
       flex-shrink: 0;
       color: $topaz;
     }
+
+    svg {
+      min-width: 18px;
+    }
   }
 }
diff --git a/src/components/Datasets/Datasets.js b/src/components/Datasets/Datasets.js
@@ -36,7 +36,9 @@ import {
   BE_PAGE,
   BE_PAGE_SIZE,
   ITERATIONS_FILTER,
-  SHOW_ITERATIONS
+  SHOW_ITERATIONS,
+  TAG_FILTER,
+  TAG_FILTER_ALL_ITEMS
 } from '../../constants'
 import { fetchArtifactTags, fetchDataSets, removeDataSets } from '../../reducers/artifactsReducer'
 import {
@@ -117,7 +119,7 @@ const Datasets = ({ isAllVersions = false }) => {
         requestParams.name = params.datasetName
         setDatasetVersions([])
       } else {
-        if (filters[ITERATIONS_FILTER] !== SHOW_ITERATIONS) {
+        if (filters[ITERATIONS_FILTER] !== SHOW_ITERATIONS || filters[TAG_FILTER] === TAG_FILTER_ALL_ITEMS) {
           requestParams['partition-by'] = 'project_and_name'
           requestParams['partition-sort-by'] = 'updated'
         }

diff --git a/src/components/Documents/Documents.js b/src/components/Documents/Documents.js
@@ -46,7 +46,9 @@ import {
   GROUP_BY_NONE,
   ITERATIONS_FILTER,
   REQUEST_CANCELED,
-  SHOW_ITERATIONS
+  SHOW_ITERATIONS,
+  TAG_FILTER,
+  TAG_FILTER_ALL_ITEMS
 } from '../../constants'
 import { fetchArtifactTags, fetchDocuments, removeDocuments } from '../../reducers/artifactsReducer'
 import { getFilterTagOptions, setFilters } from '../../reducers/filtersReducer'
@@ -111,7 +113,7 @@ const Documents = ({ isAllVersions = false }) => {
         requestParams.name = params.documentName
         setDocumentVersions([])
       } else {
-        if (filters[ITERATIONS_FILTER] !== SHOW_ITERATIONS) {
+        if (filters[ITERATIONS_FILTER] !== SHOW_ITERATIONS || filters[TAG_FILTER] === TAG_FILTER_ALL_ITEMS) {
           requestParams['partition-by'] = 'project_and_name'
           requestParams['partition-sort-by'] = 'updated'
         }

diff --git a/src/components/Files/Files.js b/src/components/Files/Files.js
@@ -37,7 +37,9 @@ import {
   GROUP_BY_NONE,
   ITERATIONS_FILTER,
   REQUEST_CANCELED,
-  SHOW_ITERATIONS
+  SHOW_ITERATIONS,
+  TAG_FILTER,
+  TAG_FILTER_ALL_ITEMS
 } from '../../constants'
 import {
   checkForSelectedFile,
@@ -113,7 +115,7 @@ const Files = ({ isAllVersions = false }) => {
         requestParams.name = params.fileName
         setFileVersions([])
       } else {
-        if (filters[ITERATIONS_FILTER] !== SHOW_ITERATIONS) {
+        if (filters[ITERATIONS_FILTER] !== SHOW_ITERATIONS || filters[TAG_FILTER] === TAG_FILTER_ALL_ITEMS) {
           requestParams['partition-by'] = 'project_and_name'
           requestParams['partition-sort-by'] = 'updated'
         }

diff --git a/src/components/ModelsPage/Models/Models.js b/src/components/ModelsPage/Models/Models.js
@@ -45,7 +45,9 @@ import {
   BE_PAGE,
   BE_PAGE_SIZE,
   ITERATIONS_FILTER,
-  SHOW_ITERATIONS
+  SHOW_ITERATIONS,
+  TAG_FILTER,
+  TAG_FILTER_ALL_ITEMS
 } from '../../../constants'
 import {
   checkForSelectedModel,
@@ -129,7 +131,7 @@ const Models = ({ fetchModelFeatureVector, isAllVersions }) => {
         requestParams.name = params.modelName
         setModelVersions([])
       } else {
-        if (filters[ITERATIONS_FILTER] !== SHOW_ITERATIONS) {
+        if (filters[ITERATIONS_FILTER] !== SHOW_ITERATIONS || filters[TAG_FILTER] === TAG_FILTER_ALL_ITEMS) {
           requestParams['partition-by'] = 'project_and_name'
           requestParams['partition-sort-by'] = 'updated'
         }