Fix [Alerts] The alert details pane doesn't close when navigating thr…

…ough pagination (#3011)
mlrun · Jan 13, 2025 · 3f9f7bf · 3f9f7bf
1 parent 5b6330d
commit 3f9f7bf
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/src/components/Alerts/AlertsView.js b/src/components/Alerts/AlertsView.js
@@ -29,9 +29,9 @@ import NoData from '../../common/NoData/NoData'
 import Pagination from '../../common/Pagination/Pagination'
 import Table from '../Table/Table'
 
-import { ALERTS_FILTERS, ALERTS_PAGE } from '../../constants'
+import { ALERTS_FILTERS, ALERTS_PAGE, ALERTS_PAGE_PATH } from '../../constants'
 import { getNoDataMessage } from '../../utils/getNoDataMessage'
-import { getCloseDetailsAlertLink } from '../../utils/link-helper.util'
+import { getCloseDetailsLink } from '../../utils/link-helper.util'
 
 import './alerts.scss'
 
@@ -98,7 +98,7 @@ const AlertsView = ({
               <>
                 <Table
                   actionsMenu={[]}
-                  getCloseDetailsLink={() => getCloseDetailsAlertLink()}
+                  getCloseDetailsLink={() => getCloseDetailsLink(ALERTS_PAGE_PATH)}
                   pageData={pageData}
                   retryRequest={handleRefreshWithFilters}
                   selectedItem={isAlertsPage ? selectedAlert : {}}
@@ -130,6 +130,7 @@ const AlertsView = ({
                   })}
                 </Table>
                 <Pagination
+                  closeParamName={ALERTS_PAGE_PATH}
                   page={pageData.page}
                   paginationConfig={paginationConfigAlertsRef.current}
                 />

diff --git a/src/constants.js b/src/constants.js
@@ -95,6 +95,7 @@ export const JOBS_MONITORING_WORKFLOWS_TAB = 'workflows'
 export const JOBS_MONITORING_SCHEDULED_TAB = 'scheduled'
 
 export const ALERTS_PAGE = 'ALERTS'
+export const ALERTS_PAGE_PATH = 'alerts'
 export const ALERTS_TAB = 'alerts'
 export const ALERTS_FILTERS = 'alerts'
 export const MODEL_ENDPOINT_RESULT = 'model-endpoint-result'

diff --git a/src/utils/link-helper.util.js b/src/utils/link-helper.util.js
@@ -57,11 +57,6 @@ export const getCloseDetailsLink = (paramName, ignoreOrigin) => {
   return ignoreOrigin ? link : generateUrlFromRouterPath(link)
 }
 
-//TODO: the getCloseDetailsAlertLink will be updated with ML-8368
-export const getCloseDetailsAlertLink = () => {
-  return `/projects/*/alerts/${window.location.search}`
-}
-
 export const getDefaultCloseDetailsLink = (params, page, tab) => {
   return `/projects/${params.projectName}/${page.toLowerCase()}${
     params.pageTab ? `/${params.pageTab}` : tab ? `/${tab}` : ''