fix defaults (#287)

mlr-org · Aug 3, 2023 · 949cef2 · 949cef2
1 parent a4517ac
commit 949cef2
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 26 deletions.
diff --git a/R/learner_C50_classif_C50.R b/R/learner_C50_classif_C50.R
@@ -35,7 +35,7 @@ LearnerClassifC50 = R6Class("LearnerClassifC50",
         seed = p_int(lower = -Inf, upper = Inf, tags = "train"),
         earlyStopping = p_lgl(default = TRUE, tags = "train"),
         label = p_uty(default = "outcome", tags = "train"),
-        na.action = p_uty(default = stats::na.pass, tags = "predict")
+        na.action = p_uty(default = "stats::na.pass", tags = "predict")
       )
       ps$add_dep("bands", "rules", CondEqual$new(TRUE))
 

diff --git a/R/learner_lme4_classif_glmer.R b/R/learner_lme4_classif_glmer.R
@@ -70,7 +70,7 @@ LearnerClassifGlmer = R6Class("LearnerClassifGlmer",
         re.form = p_uty(default = NULL, tags = "predict"),
         random.only = p_lgl(default = FALSE, tags = "predict"),
         allow.new.levels = p_lgl(default = FALSE, tags = "predict"),
-        na.action = p_uty(default = stats::na.pass, tags = "predict")
+        na.action = p_uty(default = "stats::na.pass", tags = "predict")
       )
 
       param_set$values = list(family = stats::binomial(link = "logit"))

diff --git a/R/learner_lme4_regr_lmer.R b/R/learner_lme4_regr_lmer.R
@@ -118,10 +118,7 @@ LearnerRegrLmer = R6Class("LearnerRegrLmer",
         ),
         ParamUty$new(
           id = "check.conv.singular",
-          default = 'lme4::.makeCC(
-            action = "message",
-            tol = formals(lme4::isSingular)$tol
-          )',
+          default = 'lme4::.makeCC(action = "message", tol = formals(lme4::isSingular)$tol)',
           tags = "train"
         ),
         ParamUty$new(
@@ -141,7 +138,7 @@ LearnerRegrLmer = R6Class("LearnerRegrLmer",
         ParamUty$new(id = "re.form", default = NULL, tags = "predict"),
         ParamLgl$new(id = "random.only", default = FALSE, tags = "predict"),
         ParamLgl$new(id = "allow.new.levels", default = FALSE, tags = "predict"),
-        ParamUty$new(id = "na.action", default = stats::na.pass, tags = "predict")
+        ParamUty$new(id = "na.action", default = "stats::na.pass", tags = "predict")
       ))
 
       super$initialize(

diff --git a/R/learner_partykit_surv_cforest.R b/R/learner_partykit_surv_cforest.R
@@ -40,7 +40,7 @@ delayedAssign(
           trace = p_lgl(default = FALSE, tags = "train"),
           offset = p_uty(tags = "train"),
           cluster = p_uty(tags = "train"),
-          na.action = p_uty(default = stats::na.pass, tags = "train"),
+          na.action = p_uty(default = "stats::na.pass", tags = "train"),
           scores = p_uty(tags = "train"),
 
           teststat = p_fct(default = "quadratic",

diff --git a/man/mlr_learners_classif.C50.Rd b/man/mlr_learners_classif.C50.Rd
diff --git a/man/mlr_learners_classif.glmer.Rd b/man/mlr_learners_classif.glmer.Rd
diff --git a/man/mlr_learners_regr.lmer.Rd b/man/mlr_learners_regr.lmer.Rd
diff --git a/man/mlr_learners_surv.cforest.Rd b/man/mlr_learners_surv.cforest.Rd