Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP enhancements #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

WIP enhancements #13

wants to merge 4 commits into from

Conversation

ncordon
Copy link
Contributor

@ncordon ncordon commented Sep 23, 2019 •
edited
Loading

  • Corrects transitions parsing (0 is a valid note, cannot be used as a sentinel here)
  • Adds comments to markov.go file
  • Ports rakyll/portmidi to gomidi/portmididrv which seems to have more updated support

@kuba-- kuba-- requested a review from jfontan September 23, 2019 22:54
@kuba--
Copy link
Member

kuba-- commented Sep 23, 2019

Resolve conflicts, first

@jfontan jfontan requested review from smacker and removed request for smacker September 24, 2019 09:06
@ncordon ncordon force-pushed the misc.enhancements branch from 7a9ba0d to a841d90 Compare October 7, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfontan jfontan Awaiting requested review from jfontan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncordon @kuba--