Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning if a server sends back non-XML #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a warning if a server sends back non-XML #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sickle/response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
:copyright: Copyright 2015 Mathias Loesch
"""

import logging
from lxml import etree

XMLParser = etree.XMLParser(remove_blank_text=True, recover=True, resolve_entities=False)
Expand Down Expand Up @@ -34,6 +35,10 @@ def raw(self):
@property
def xml(self):
"""The server's response as parsed XML."""
if (self.http_response.headers.get('Content-Type') !=
'application/xml'):
logging.warn('received non-XML response %s',
self.http_response.headers.get('Content-Type'))
return etree.XML(self.http_response.content,
parser=XMLParser)

Expand Down