-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slack and new publication info to readme #78
Conversation
README.md
Outdated
If you are interested in machine learning models for LAM, have questions about our implementation or ideas for extending it, feel free to get in touch. | ||
You can open a github issue on this page, or (if more suitable) send an email to [[email protected]](mailto:[email protected]). | ||
If you are interested in machine learning models for LAM, have questions about the implementation or ideas for extending it, feel free to get in touch. | ||
You can join the [slack channel](https://join.slack.com/t/ml-lam/shared_invite/zt-2t112zvm8-Vt6aBvhX7nYa6Kbj_LkCBQ), open a github issue on this page, or (if more suitable) send an email to [[email protected]](mailto:[email protected]). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be careful when publishing this kind of information. I was involved in another project where we couldn't add any new members to the slack channel because bots had spammed the slack join link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point 😱 Currently, members from a curated list of domains (unis, met services mostly) can join without invite. The link you are about to post can be used 400-times. If abused, the link can be deactivated and a new one generated. All bots, must be removed manually by the workspace owner. That sounds annoying...
Alternatively, we can set up admin admission via notification in one of our slack channels (https://slack.com/help/articles/115004854783-Require-admin-approval-for-workspace-invitations). Since, we are all admins this could be a good solution. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes thanks for pointing this out 👐 I did not know if bots would be an issue with slack, but clearly it can be then.
I don't really get what will happen if you set up this admin approval. I guess you will not immediately join through the link then, but send a request to join? And then any admin can accept it. In that case we would definitely not want the option where requests are sent to all admins via Slackbot, as then everyone will be spammed by every request. But one can set it to post the requests to a specific channel, which could work fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sadamov, Yes I think that might mitigate the problem. If I remember well, the issue was that the bots activate the join link, but never actually join the slack channel. Resulting in 400 people in limbo for activation. Which blocks any new user from joining.
Using admin rights to actively reject them might solve the issue. It will also give you an idea if the link is getting abused, so that you can remove it if it becomes problematic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a good idea to make a specific channel for it? Or otherwise make a post to clarify that invite requests will show up in random, so people are not confused about it (e.g. if someones colleague joins it might not be obvious where to find the message to accept the request).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking that I'll also clarify in the readme the procedure for joining slack, so people aren't deterred when you have to request to join
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, can be merged
NOTE: newcomers to the slack workspace must be accepted by any admin, who will be notified in the slack #random channel.
Describe your changes
This PR just contains some updates and clarifications to the readme. In particular:
Type of change
Checklist before requesting a review
pull
with--rebase
option if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee