-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for zarr-python 3 #51
Conversation
Thanks @kashif for the PR. I assume that this breaks for |
It would be good if we can still support zarr v2. The tests over at #53 might help to test compatibility. |
let me test! |
thanks @observingClouds all the tests pass with zarr v2 and v3 |
Great! Could you actually please merge observingClouds:testing/zarr also into your branch here then we also have an automatic test for zarr v2 and zarr v3. Then we see the test result also here in the CI. |
@observingClouds done! feel free to run the CI when ready |
All right @kashif all tests are indeed passing 😎 Could you just add a CHANGELOG entry and add yourself to the pyproject.toml author list? |
This looks great @kashif! Thanks for adding this and welcome to the mllam community :) |
Congrats on your first merged contribution 🎉 |
Describe your changes
Update the zarr compressors API and fixed some warnings for zarr v3.
Issue Link
was getting the error:
Type of change
Checklist before requesting a review
pull
with--rebase
option if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee