[Testing] rubocop default cops TODOs

[dazza-codes]

Looking at default rubocop TODOs. Started with a blank slate, i.e.

rm .rubocop*
rubocop --auto-gen-config  # creates todo file
echo "inherit_from: .rubocop_todo.yml" > .rubocop.yml
rubocop # should be no problems

Then review each of the TODO items, first focusing on the ones with large offense counts. Move the config from .rubocop_todo.yml into the .rubocop.yml and read the configuration options for that cop at http://rubocop.readthedocs.io/en/latest/cops/ and then set it to something that might work. Then run rubocop again to see what that complains about. Try to get a very small set of complaints, if any. Then use rubocop --auto-correct to tidy things up. Then commit the change and move onto the next cop. Once all the main cops are configured in this way, you have a .rubocop.yml file that represents how you want rubocop to respect your code. It might get tweaked, depending on how restrictive or lenient you want rubocop to be.

For reference or comparison, consider the Thoughtbot ruby style:
https://github.com/thoughtbot/guides/tree/master/style/ruby

[coveralls]

Coverage remained the same at 95.706% when pulling af15fe2 on dpn-admin:rubocop-default-todos into a1bf1e4 on mlibrary:master.

[coveralls]

Coverage remained the same at 95.706% when pulling af15fe2 on dpn-admin:rubocop-default-todos into a1bf1e4 on mlibrary:master.

[coveralls]

Coverage remained the same at 95.706% when pulling 88fe747 on dpn-admin:rubocop-default-todos into a1bf1e4 on mlibrary:master.

[coveralls]

Coverage remained the same at 95.706% when pulling a1260b5 on dpn-admin:rubocop-default-todos into a1bf1e4 on mlibrary:master.

[coveralls]

Coverage remained the same at 95.706% when pulling a1260b5 on dpn-admin:rubocop-default-todos into a1bf1e4 on mlibrary:master.

[coveralls]

Coverage remained the same at 95.706% when pulling 991ecfe on dpn-admin:rubocop-default-todos into a1bf1e4 on mlibrary:master.