Slur Filter Warning #867
Merged
Slur Filter Warning #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjmarf
requested review from
ShadowJonathan and
EricBAndrews
and removed request for
a team
EricBAndrews
requested changes
Jan 28, 2024
There was a problem hiding this comment.
Looks good! I've left a couple minor suggestions. It also appears that the slur filter does not get reset when switching to an instance with no slur filter:
- Switch to a
lemmy.mlaccount (or an account on any instance with slur filter) - Switch to
test-mlem(or an account on any instance without a slur filter) - Try to compose a post with a slur
The slur filter from the previous instance will still be applied
Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Lemmy allows instances to set a slur filter. Users cannot create posts that match the filter regex. The user can create a comment that matches the regex - however, all matches contained within the comment are replaced with
*removed*.Implementation
This PR modifies the
PostComposerViewto show a"xyz" is disallowedbanner if the post matches the slur filter regex. The regex is checked dynamically every time the post content is modified.This improves the user experience - previously, the user would just get an
"error: slur"notification, with no hint of where in the post the slur is. This could have been confusing, especially if a slur was included accidentally as part of another word, or the user was unaware that their instance blocked a certain word (an example would be"bitch"onlemmy.ml).What about comments?
Edit: Added for comments too!
Original message:
Should I implement something similar for comments? Lemmy doesn't actually stop the user from posting a comment containing slurs. I'm not sure what the best approach is here. Do we stop the user from posting their comment? Do we still allow them to post, but give them a warning? Or do we not do anything at all?