Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CI builds for forked PRs #865

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions .github/actions/ci_xcodebuild/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ inputs:
xcodebuild_action:
required: true

permissions:
# This workflow needs write access to the checks to publish
# the results of the tests via xcresulttool.
checks: write

runs:
using: "composite"
steps:
Expand All @@ -30,12 +35,19 @@ runs:
action: "${{ inputs.xcodebuild_action }}"
result-bundle-path: build_results.xcresult

- uses: kishikawakatsumi/xcresulttool@v1
name: Publish build results
#- uses: kishikawakatsumi/xcresulttool@v1
# name: Publish build results
# with:
# path: build_results.xcresult
# upload-bundles: never # Permission issues with uploading
# show-passed-tests: false
# if: success() || failure()
# # ^ This is important because the action will be run
# # even if the test fails in the previous step.

- name: Publish Test Results
uses: EnricoMi/publish-unit-test-result-action@v2
if: always()
with:
path: build_results.xcresult
upload-bundles: never # Permission issues with uploading
show-passed-tests: false
if: success() || failure()
# ^ This is important because the action will be run
# even if the test fails in the previous step.
files: |
**/*.xcresult
24 changes: 16 additions & 8 deletions .github/workflows/ci_build_15.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,23 @@ name: CI - Build & Test - Xcode 15

on:
push:
branches:
- master
- dev
branches:
- master
- dev

pull_request:
branches:
- master
- dev
branches:
- master
- dev

jobs:
Build:
permissions: write-all
permissions:
pull-requests: 'write'
# This workflow needs write access to the checks to publish
# the results of the tests via xcresulttool.
checks: write

runs-on: macos-13
steps:
- name: Checkout
Expand All @@ -27,7 +32,10 @@ jobs:
xcodebuild_action: "build"

Test:
permissions: write-all
permissions:
# This workflow needs write access to the checks to publish
# the results of the tests via xcresulttool.
checks: write
runs-on: macos-13
steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion Mlem/API/APIRequest.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import Foundation

// MARK: - APIRequest

enum APIRequestError: Error {
enum APIRequestError: Error
Copy link
Member

@Sjmarf Sjmarf Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing remnant?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Trying to make sure Xcode error reporting works.

case authenticationRequired
case undefinedSession
}
Expand Down
Loading