Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toggling "hide read" not immediately updating #852

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

Sjmarf
Copy link
Contributor

@Sjmarf Sjmarf commented Jan 11, 2024

Toggling "Hide Read" via the ellipsis menu in a feed wouldn't immediately work - you'd have to exit and re-enter the feed to see changes. Now, the feed refreshes immediately with the new setting applied.

I don't really know why this fixes it, but it works 🤔

@Sjmarf Sjmarf requested a review from a team as a code owner January 11, 2024 22:27
@Sjmarf Sjmarf requested review from JakeShirley and mormaer and removed request for a team January 11, 2024 22:27
@Sjmarf Sjmarf changed the title Fix toggle hide read not immediately updating Fix toggling "hide read" not immediately updating Jan 11, 2024
@Sjmarf Sjmarf added the bug Something isn't working label Jan 11, 2024
Copy link
Member

@JakeShirley JakeShirley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best kind of fix!

@Sjmarf Sjmarf merged commit 0672654 into dev Jan 12, 2024
4 checks passed
@Sjmarf Sjmarf deleted the sjmarf/hide-read-fix branch January 12, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants