Fix flowDidChange being called extraneously
#850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjmarf
requested review from
mormaer and
ShadowJonathan
and removed request for
a team
EricBAndrews
requested changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flowDidChangewas called viaonAppearon theWindowview.onAppearwas triggered when navigating back from an external link, which calledflowDidChange. I've fixed this by only callingflowDidChangethe first timeonAppearis triggered.This might be related to the app store review about having to re-authenticate when navigating back from an external link?
It might also be related to the error haptic that I've been getting when navigating back from a link, though I'm not sure because I can't reproduce that bug at the moment. It might be dependent on internet speed or something, because I was able to reproduce it consistently yesterday and nothing's changed since then.