Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap tab bar to show/hide sidebar on iPad #827

Merged
merged 2 commits into from
Dec 24, 2023

Conversation

boscojwho
Copy link
Contributor

Checklist

  • I have read CONTRIBUTING.md
  • I have described what this PR contains
  • This PR addresses one or more open issues that were assigned to me:
    - list issue(s) here
  • If this PR alters the UI, I have attached pictures/videos

Pull Request Information

About this Pull Request

Fix issue where tapping on tab bar doesn't cause sidebar to hide on regular size class (e.g. iPad).

@boscojwho boscojwho requested a review from a team as a code owner December 23, 2023 07:48
@boscojwho boscojwho requested review from mormaer and ShadowJonathan and removed request for a team December 23, 2023 07:48
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@boscojwho boscojwho merged commit a285b8a into dev Dec 24, 2023
4 checks passed
@boscojwho boscojwho deleted the bosco/fix-sidebar-show-hide-tab-navigation branch December 24, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants