Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Post Composer, uploading avatar/banner #818

Merged
merged 2 commits into from
Dec 21, 2023
Merged

New Post Composer, uploading avatar/banner #818

merged 2 commits into from
Dec 21, 2023

Conversation

Sjmarf
Copy link
Member

@Sjmarf Sjmarf commented Dec 17, 2023 •
edited
Loading

  • Abstracted image upload logic out of PostComposerView and into a dedicated LinkAttachmentModel.
  • Added options to change avatar and banner in account settings.
  • Added more ways to upload images. In addition to choosing an image from Photos, you can now choose an image from Files or paste an image/url from the clipboard.
  • Redesigned the post composer view.

Issues

@Sjmarf Sjmarf requested a review from a team as a code owner December 17, 2023 18:49
@Sjmarf Sjmarf requested review from mormaer and EricBAndrews and removed request for a team December 17, 2023 18:49
EricBAndrews
EricBAndrews requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the cursor pagination hotfix got overridden here, but other than that looks good!

Mlem/API/Requests/Post/GetPosts.swift Outdated Show resolved Hide resolved
Mlem/Models/Trackers/Post Tracker.swift Outdated Show resolved Hide resolved
@Sjmarf Sjmarf requested a review from EricBAndrews December 20, 2023 21:40
EricBAndrews
EricBAndrews approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Sjmarf Sjmarf merged commit 789ac13 into dev Dec 21, 2023
4 checks passed
@Sjmarf Sjmarf deleted the sjmarf/change-pfp branch December 21, 2023 06:30
@EricBAndrews EricBAndrews mentioned this pull request Dec 21, 2023
Merged
EricBAndrews pushed a commit that referenced this pull request Dec 21, 2023
@Sjmarf @EricBAndrews
New Post Composer, uploading avatar/banner (#818)
da1b28a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricBAndrews EricBAndrews EricBAndrews approved these changes

@mormaer mormaer Awaiting requested review from mormaer mormaer is a code owner automatically assigned from mlemgroup/mlem-dev-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Account Settings Profile Editing - Avatar upload
2 participants
@Sjmarf @EricBAndrews