Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor pagination hotfix #817

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Conversation

EricBAndrews
Copy link
Member

@EricBAndrews EricBAndrews commented Dec 17, 2023

Hotfix to address prod issue where 0.19 instances are unable to properly paginate, resulting in "end of feed" after one page.

Tested on lemmy.ca and lemmy.ml.

  • Updates the pagination cursor from page_v2 to the correct page_cursor
  • Updates shouldLoadContentAfter to only return true once per page of posts, which avoids a multithreading issue where multiple concurrent load calls triggered an erroneous "end of feed" status due to a race condition on currentCursor. Note that this should properly be handled by migrating PostTracker to be based on StandardTracker.

@EricBAndrews EricBAndrews requested a review from a team as a code owner December 17, 2023 17:59
@EricBAndrews EricBAndrews requested review from JakeShirley and mormaer and removed request for a team December 17, 2023 17:59
@EricBAndrews EricBAndrews merged commit f716294 into master Dec 18, 2023
6 checks passed
@EricBAndrews EricBAndrews deleted the eric/cursor-pagination-hotfix branch December 18, 2023 14:59
EricBAndrews added a commit that referenced this pull request Dec 18, 2023
EricBAndrews added a commit that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants