Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension cleanup #814

Merged
merged 4 commits into from
Dec 17, 2023
Merged

Extension cleanup #814

merged 4 commits into from
Dec 17, 2023

Conversation

EricBAndrews
Copy link
Member

@EricBAndrews EricBAndrews commented Dec 17, 2023

This PR cleans up the extensions folder, making the following changes:

  • All extensions are now named Base+Extension
  • All extension files now contain just one extension or variable. Exceptions are made for extensions that group static members (e.g., Color+Colors) and extensions that define the same function in multiple contexts (e.g., Error+ToEquatableError)
  • All extensions are now grouped in folders according to what they extend, with some exceptions:
    • Mocks all live in the Mock group
    • View modifiers all live in the View Modifiers group
    • Tracker item conformance extensions all live in the Tracker Items group
  • Removed some unused extensions

@EricBAndrews EricBAndrews requested a review from a team as a code owner December 17, 2023 01:54
@EricBAndrews EricBAndrews requested review from WestonHanners and JakeShirley and removed request for a team December 17, 2023 01:54
@EricBAndrews EricBAndrews force-pushed the eric/extension-cleanup branch from 9d572ea to b1d45b0 Compare December 17, 2023 01:58
Copy link
Contributor

@boscojwho boscojwho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improvement over current state:
It builds, it runs, it heckin` passes 🐈

@EricBAndrews EricBAndrews merged commit 175017a into dev Dec 17, 2023
4 checks passed
@EricBAndrews EricBAndrews deleted the eric/extension-cleanup branch December 17, 2023 02:37
EricBAndrews added a commit that referenced this pull request Dec 18, 2023
EricBAndrews added a commit that referenced this pull request Dec 18, 2023
EricBAndrews added a commit that referenced this pull request Dec 18, 2023
EricBAndrews added a commit that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants