Remove most imports of UIKit #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twizmwazin
requested review from
JakeShirley and
EricBAndrews
and removed request for
a team
twizmwazin
commented
Dec 8, 2023
| if success { | ||
| print("Save finished!") | ||
| } else { | ||
| print("Error saving photo: \(String(describing: error?.localizedDescription))") |
There was a problem hiding this comment.
Probably good to call out we should maybe handle this better in the future.
There was a problem hiding this comment.
Agreed, OOS here but I've opened an issue: #802
| @@ -7,10 +7,9 @@ | |||
| // | |||
|
|
|||
| import SwiftUI | |||
| import UIKit | |||
|
|
|||
| /// A class responsible for displaying important notifications to the user | |||
There was a problem hiding this comment.
why is this an enum, this makes it a value type instead of a reference type.
EricBAndrews
approved these changes
Dec 8, 2023
|
Should be good to merge with a rebase + passing CI |
twizmwazin
force-pushed
the
remove-most-uikit
branch
from
5e22ba5 to
ecb2800
Compare
|
As far as I can tell the CI is failing due to my fork not having write permission on some resource. The tests themselves appear to be passing. |
twizmwazin
force-pushed
the
remove-most-uikit
branch
from
ecb2800 to
274709a
Compare
|
Looks like it. Build and test works fine on my machine--bypassing branch protections to merge w/o passing CI. |
EricBAndrews
pushed a commit
that referenced
this pull request
Dec 18, 2023
EricBAndrews
pushed a commit
that referenced
this pull request
Dec 18, 2023
EricBAndrews
pushed a commit
that referenced
this pull request
Dec 18, 2023
EricBAndrews
pushed a commit
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- list issue(s) here
Pull Request Information
About this Pull Request
Describe what this PR contains in as much detail as possible
This PR remove almost all of the references to UIKit. Most of these were nothing more than deleting the import, the photo saving required a change. I would appreciate if someone could check I did that correctly!
Screenshots and Videos
In case this PR changes something in the UI, please include screenshots or videos of this new feature
None, any functional change is a bug
Additional Context
Any additional context you'd like to add to help us review this PR
Removing UIKit dependency and being 100% on SwiftUI would allow native Mac support someday.