Colorize voting icons and text in compact posts and comments #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twizmwazin
requested review from
WestonHanners and
EricBAndrews
and removed request for
a team
Sjmarf
approved these changes
Dec 10, 2023
twizmwazin
force-pushed
the
compact-colorize-votes
branch
from
f5193a5 to
b9e45af
Compare
|
As mentioned in my other PR, the CI failure seems to be some permission issue likely due to the fork. |
twizmwazin
force-pushed
the
compact-colorize-votes
branch
from
b9e45af to
e8728ba
Compare
Same as other PR, once it's up-to-date with dev I'll test locally and bypass branch protections to merge. |
twizmwazin
force-pushed
the
compact-colorize-votes
branch
from
e8728ba to
1eff33b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- list issue(s) here
Pull Request Information
About this Pull Request
Describe what this PR contains in as much detail as possible
This PR adds colors to the upvote/downvote icons and text for posts and comments when in compact views.
Screenshots and Videos
In case this PR changes something in the UI, please include screenshots or videos of this new feature
Additional Context
Any additional context you'd like to add to help us review this PR
If this was intentionally omitted as a general preference, I can see about integrating a setting for this. However, having colors makes it considerably easier to see that a vote has been placed and is consistent with non-compact views.