Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- Slack
Pull Request Information
This PR adds some logic to prompt users to reauthenticate if their saved credentials are invalid, namely:
invalidSession
errors are now thrown for any credential failure responseAddSavedInstanceView
now catches those as login failures instead of manually checking for.isIncorrectLogin
on a response errorContentView
instead of being programmatically presented through theNotificationDisplayer
invalidSession
flag on theErrorHandler
when dismissed, which prevents an invalid session message being erroneously displayed when cancelling the token refresh and switching accountsTesting steps
To simulate the use case of users attempting to use accounts saved in Mlem before their instance updated to 0.19, perform the following:
The new flow should trigger.
For thoroughness, I have tested both the cases where the accounts were added in an older version of Mlem (
release-1.1
) and the latest TestFlight build (beta-1.1.1-RC-2
), though that shouldn't matter.