Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made image share share image directly instead of url #768

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

EricBAndrews
Copy link
Member

Checklist

  • I have read CONTRIBUTING.md
  • I have described what this PR contains
  • This PR addresses one or more open issues that were assigned to me:
    - list issue(s) here
  • If this PR alters the UI, I have attached pictures/videos

Fixes a bug with the new image viewer where it would share the image URL instead of the image itself. To support this, adds a .shareImage case to MenuFunction.

@EricBAndrews EricBAndrews requested a review from a team as a code owner November 19, 2023 18:07
@EricBAndrews EricBAndrews requested review from WestonHanners and ShadowJonathan and removed request for a team November 19, 2023 18:07
Copy link
Member

@Sjmarf Sjmarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Works as expected

@EricBAndrews EricBAndrews merged commit baa54a8 into dev Nov 20, 2023
4 checks passed
@EricBAndrews EricBAndrews deleted the eric/sheet-image-viewer-save-fix branch November 20, 2023 20:28
boscojwho pushed a commit that referenced this pull request Nov 23, 2023
@Sjmarf Sjmarf mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants