Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better 'no posts to be found' message #714

Merged
merged 5 commits into from
Oct 28, 2023
Merged

Better 'no posts to be found' message #714

merged 5 commits into from
Oct 28, 2023

Conversation

Sjmarf
Copy link
Member

@Sjmarf Sjmarf commented Oct 10, 2023

Centered the loading graphic and replaced "no posts to be found" message (see images).

@Sjmarf Sjmarf requested a review from a team as a code owner October 10, 2023 21:59
@Sjmarf Sjmarf requested review from ShadowJonathan and EricBAndrews and removed request for a team October 10, 2023 21:59
@Sjmarf
Copy link
Member Author

Sjmarf commented Oct 11, 2023

Added the fancy error-message from ExpandedPostView too

@Sjmarf
Copy link
Member Author

Sjmarf commented Oct 14, 2023

In future we could do something similar for the inbox tab perhaps, offering a button to show all messages if the user is only viewing unread messages

Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Minor wording comment, but fantastic work as always

Mlem/Views/Tabs/Feeds/Components/NoPostsView.swift Outdated Show resolved Hide resolved
@Sjmarf Sjmarf merged commit 5872307 into dev Oct 28, 2023
2 of 6 checks passed
@Sjmarf Sjmarf deleted the sjmarf/feed-errors branch October 28, 2023 08:06
boscojwho pushed a commit that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants