Search context menus #705
Merged
Search context menus #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjmarf
requested review from
JakeShirley and
EricBAndrews
and removed request for
a team
boscojwho
requested changes
Oct 11, 2023
There was a problem hiding this comment.
Looks good, works as expected:
- Would it be possible to move the destructive actions (block/unsubscribe) into its own section in the menu? Always makes me a little nervous having a destructive menu item as the first option on a long press menu.
- Not PR block worthy though, if too big of a change for this PR to how menu functions/items are generated.
When you say 'section', do you mean adding a divider or adding a separate sub-menu like we use for the 'top' sort modes in the feed? I don't think misclicks should be a huge issue - the app asks for confirmation for both unsubscribing and blocking anyways |
Sjmarf
force-pushed
the
sjmarf/search-context-menus
branch
from
37c82e9 to
7623d51
Compare
|
I've had to rewrite most of this - it was quite old haha. I've added some extra changes that weren't present in the previous version:
|
boscojwho
approved these changes
Nov 10, 2023
|
Looks good:
|
boscojwho
pushed a commit
that referenced
this pull request
Nov 23, 2023
Co-authored-by: Bosco Ho <[email protected]> (cherry picked from commit 3a2a7c0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets you share and block communities and users from a context menu on each search result.
