Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inbox unread counter bug #701

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Fixed inbox unread counter bug #701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions Mlem/Views/Tabs/Inbox/Inbox View Logic.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,16 @@ extension InboxView {

// MARK: - Replies

/// Marks a comment reply as read or unread. Has no effect if the requested read status is already the current read status
/// - Parameters:
/// - commentReplyView: commentReplyView to mark
/// - read: true to mark as read, false to mark as unread
func markCommentReplyRead(commentReplyView: APICommentReplyView, read: Bool) async {
// skip noop case
guard commentReplyView.commentReply.read != read else {
return
}

do {
let response = try await commentRepository.markCommentReadStatus(
id: commentReplyView.id,
Expand Down Expand Up @@ -212,7 +221,16 @@ extension InboxView {

// MARK: Mentions

/// Marks a person mention as read or unread. Has no effect if the requested read status is already the current read status
/// - Parameters:
/// - mention: mention to mark
/// - read: true to mark as read, false to mark as unread
func markMentionRead(mention: APIPersonMentionView, read: Bool) async {
// skip noop case
guard mention.personMention.read != read else {
return
}

do {
let updatedMention = try await apiClient.markPersonMentionAsRead(
mentionId: mention.personMention.id,
Expand Down