Added updated time display #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricBAndrews
requested review from
WestonHanners and
JakeShirley
and removed request for
a team
|
Nice. Is it worth adding a way to show the published time still? Maybe tapping on that icon in the info bar shows the publish date? We don't necessarily have to do that in this PR though |
Sjmarf
approved these changes
Sep 30, 2023
|
Agree that the published time should be accessible somehow--I've opened a follow-up issue #679. The UX might take some thinking--a simple tap would lead to unexpected behavior on something like a compact post where the hitbox to navigate to the post itself is already quite small. We can possibly look into displaying rich metadata with the context menu? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- closes Show updated time on comments #156
Pull Request Information
This PR changes posts and comments to display updated time instead of published if the item has been edited: