Image uploading

[Sjmarf]

Lets you attach images to posts.

• Closes Implement uploading API #165
• Closes Upload media #138

The animation for the image-picker sheet closing is broken on iOS 17, but works on previous iOS versions. This is just a visual bug though.

[mormaer]

Based on the possible leaking of images I think we should address that in some respect as part of this PR?

[boscojwho]

Does the app ask for iCloud Drive user permission on launch for this PR?

• Wondering because I can't test on device right now, but it asked me when I ran it in simulator.

[Sjmarf]

Does the app ask for iCloud Drive user permission on launch for this PR?

I didn't run into this. I'm using Apple's Photo picker, which supposedly handles all of the permissions stuff for us

[boscojwho]

Should we surface the failure reason to users?

• I tried to upload twice in simulator, and both times it looked like it was going to finish, then just "Failed".
• Debugged it and it was a timeout, even though the upload operation only took ~5 seconds?
• Some possibly useful errors to surface
  i. timeout
  ii. file too big
  iii. instance doesn't support images (is this a thing?)

Uploading: 40.0%
Uploading: 42.0%
Uploading: 57.0%
Uploading: 60.0%
Uploading: 76.0%
Upload failed: Optional("Request error: error sending request for url (http://pictrs:8080/image): operation timed out")
Upload failed: Response is nil

[boscojwho]

Does the app ask for iCloud Drive user permission on launch for this PR?

I didn't run into this. I'm using Apple's Photo picker, which supposedly handles all of the permissions stuff for us

Cool, ignore then, probably just a simulator/macOS thing.

[mormaer]

Couple of comments, if some will prove a pain we could address them in a follow up - I have a PR mostly ready for #651 which will require me to move things around a bit once this goes in as the session no longer holds on to a URL as it proved a headache to support dynamic resolution while the requests work that way... 😭 so perhaps addressing it as part of the other PR will make more sense and avoid blocking this any further...

one additional question, do we catch and remove an uploaded file if the user cancels the post without submitting, or only if they cancel the image directly?

[Sjmarf]

one additional question, do we catch and remove an uploaded file if the user cancels the post without submitting, or only if they cancel the image directly?

No, we don't - I'd forgotten about that case. I'll add that in tomorrow 👍

[Sjmarf]

• Debugged it and it was a timeout, even though the upload operation only took ~5 seconds?

I had this issue with test-mlem, but it was working fine on other instances.

[Sjmarf]

i. timeout

Sure, I'll add support for this.

ii. file too big

Done this already

iii. instance doesn't support images (is this a thing?)

Perhaps. I'll find out

[mormaer]

🖼️ -> 🚀

I reckon we're doing everything we can to make the user aware / proactively removing the images if they don't post etc 👍