Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - do not pass 'localhost' when present in get user request #643

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

mormaer
Copy link
Collaborator

@mormaer mormaer commented Sep 23, 2023

Checklist

  • I have read CONTRIBUTING.md
  • I have described what this PR contains
  • This PR addresses one or more open issues that were assigned to me:
    - no issue, just getting local environments supported
  • If this PR alters the UI, I have attached pictures/videos

Pull Request Information

About this Pull Request

Setting up a local environment and we don't want to pass user@localhost, as the backend expects the host URL to include a domain. In the case of a local environment passing only the username is what we want to do.

Screenshots and Videos

LOCAL

Additional Context

Instructions on setting up a local development environment can be found here:
https://join-lemmy.org/docs/contributors/02-local-development.html

@mormaer mormaer requested a review from a team as a code owner September 23, 2023 20:31
@mormaer mormaer requested review from WestonHanners and ShadowJonathan and removed request for a team September 23, 2023 20:31
@mormaer mormaer enabled auto-merge (squash) September 23, 2023 20:42
@mormaer mormaer merged commit b513ec3 into dev Sep 23, 2023
4 checks passed
@mormaer mormaer deleted the fix-allow_localhost_login branch September 23, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants