Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed settings icon sizing issues #642

Merged
merged 2 commits into from
Sep 23, 2023
Merged

Conversation

EricBAndrews
Copy link
Member

Checklist

Pull Request Information

This PR fixes settings icons displaying as too large on iOS 17. It also adds a very light border to the app icon settings item so that icons with white backgrounds (i.e., Classic Lemmy) have delineated borders.

iOS 17

iOS 17

iOS 17 (Classic Lemmy icon)

iOS 17 Classic Lemmy

iOS 16

iOS 16

@EricBAndrews EricBAndrews requested a review from a team as a code owner September 23, 2023 16:16
@EricBAndrews EricBAndrews requested review from mormaer and ShadowJonathan and removed request for a team September 23, 2023 16:16
@EricBAndrews EricBAndrews merged commit 69032a1 into dev Sep 23, 2023
@EricBAndrews EricBAndrews deleted the eric/settings-icons-fix branch September 23, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants