Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- New post composer destroys composed post without confirmation on down-swipe #602
- User feedback: Want to read what they're responding to while create/editing.
Pull Request Information
About this Pull Request
This PR includes two UI changes to Post editor and Response editor when presented as sheets:
.medium
presentation detent, while allowing users to interact with the view behind it while in.medium
detent.Additional Notes
Sheet initially presents at
.medium
detent before moving to.large
on initial presentation:.large
, we should pass aselection
binding to.presentationDetents(...)
, but doing so causes the content view to call into its body, resulting in visible lag when switching between detents..sheet(...)
expects presentation detent modifiers to be applied on the root view.Screenshots and Videos
Comment.editor.mov
post.editor.mov