Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix large post link type layout #631

Merged
merged 2 commits into from
Sep 23, 2023

Conversation

boscojwho
Copy link
Contributor

@boscojwho boscojwho commented Sep 20, 2023

Checklist

Pull Request Information

About this Pull Request

  • Fixes LargePost layout for .link post type getting cut off in landscape mode on iPad (especially when sidebar is open).

Screenshots and Videos

Before Fix (latest /dev build)

Simulator Screenshot - iPad Pro (11-inch) (4th generation) - 2023-09-20 at 00 30 20

After Fix (iPad)

iPad.mov

After Fix (iPhone)

iPhone.mov

Additional Context

  • Tested on iOS 16.4 simulator, iOS 17 simulator, iPhone 13 mini (iOS 17 RC).

@boscojwho boscojwho requested a review from a team as a code owner September 20, 2023 07:26
@boscojwho boscojwho requested review from WestonHanners and ShadowJonathan and removed request for a team September 20, 2023 07:26
@EricBAndrews
Copy link
Member

Merging per 12hr principle

@EricBAndrews EricBAndrews merged commit 6fcc165 into dev Sep 23, 2023
4 checks passed
@EricBAndrews EricBAndrews deleted the bosco/fix-large-post-link-type-layout branch September 23, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants