Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hacked images to be smooth for TF release #614

Merged
merged 2 commits into from
Sep 16, 2023
Merged

Hacked images to be smooth for TF release #614

merged 2 commits into from
Sep 16, 2023

Conversation

EricBAndrews
Copy link
Member

Checklist

  • I have read CONTRIBUTING.md
  • I have described what this PR contains
  • This PR addresses one or more open issues that were assigned to me:
    - Slack
  • If this PR alters the UI, I have attached pictures/videos

Pull Request Information

This PR applies a band-aid fix to scrolling performance by locking all images into a square and all web complexes into a rectangle.

It also updates CommunityLinkView to use the new navigation enum type.

@EricBAndrews EricBAndrews requested a review from a team as a code owner September 16, 2023 22:11
@EricBAndrews EricBAndrews requested review from WestonHanners and mormaer and removed request for a team September 16, 2023 22:11
mormaer
mormaer approved these changes Sep 16, 2023
View reviewed changes
Copy link
Contributor

@mormaer mormaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@EricBAndrews EricBAndrews merged commit d681697 into dev Sep 16, 2023
@EricBAndrews EricBAndrews deleted the eric/scroll-hack branch September 16, 2023 22:42
boscojwho added a commit that referenced this pull request Sep 19, 2023
@boscojwho
Merge branch 'dev' into bosco/tab-bar-navigation-2
5a5c6df 
* dev:
  Restructured onboarding (#613)
  bumped version (#624)
  Added a "classic Lemmy" icon (#619)
  Hacked images to be smooth for TF release (#614)
  SiteVersion enum (#604)

# Conflicts:
#	Mlem/Views/Shared/Links/Community/CommunityLinkView.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mormaer mormaer mormaer approved these changes

@WestonHanners WestonHanners Awaiting requested review from WestonHanners WestonHanners is a code owner automatically assigned from mlemgroup/mlem-dev-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EricBAndrews @mormaer