Restructured onboarding #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mormaer
requested review from
ShadowJonathan and
EricBAndrews
and removed request for
a team
mormaer
commented
Sep 16, 2023
mormaer
force-pushed
the
restructure_onboarding
branch
2 times, most recently
from
f1b2a18 to
b457d51
Compare
4 tasks
mormaer
force-pushed
the
restructure_onboarding
branch
from
b457d51 to
0cf0e0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- Partially addresses Onboarding Enhancements #534
Pull Request Information
About this Pull Request
This PR makes some changes to our onboarding to split the new and existing user flows into separate navigation stacks rather than a single tab view. This was discussed in the dev chat the other week and agreed.
In addition to this there is a basic transition flow now shown when the application changes its flow. This is mostly to hide the janky-jank that happens when we're trying to do things like dismissing modals but at the same time we want to rebuild the applications views from the root.
The view itself is basic and just displays a spinner and some text, we can iterate on this and make it fancy if we like, however it will only be shown momentarily so I've not gone any further with it in this PR.
I've also removed the What is Lemmy? link from the add account screen in this PR. With onboarding now present the two ways this screen is accessed is either from inside the application where the user already has an account (so knows what Lemmy is) or via the new user flow which has screens dedicated to explaining Lemmy/Federation.
Screenshots and Videos
onboarding.mov
Additional Context
There is still an issue present in onboarding due to the use of our
LazyVStackinside the instances view, which causes problems if you scroll up/down the list. We have discussed limiting the number of instances shown to ~30, allowing us to use aVStackwhich resolves this problem.I'll do that, and add basic search functionality to the instances in my next PR.