Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use enum navigation path #609

Merged
merged 12 commits into from
Sep 15, 2023
Merged

Use enum navigation path #609

merged 12 commits into from
Sep 15, 2023

Conversation

boscojwho
Copy link
Contributor

See PR #585

@boscojwho
- Add navigation routes for non-settings paths.
1f2779f
@boscojwho
- Add environment value for navigation routes.
ce74f7d
@boscojwho
- Add AnyNavigationPath so view modifiers (or anything else) that n…
de74281 
…eed a reference to a navigation path can use whatever.
@boscojwho
- *WIP* Use NavigationRoute enum to configure navigation path.
21da0a7
@boscojwho
Use enum route to construct navigation path, where possible.
630a3eb 
Note:
- Exception is in sidebar.
@boscojwho
- Vary what value is passed to NavigationLink based on context.
6a6b276
@boscojwho
- Move NavigationContext to separate file.
014685c
@boscojwho
- Use navigation router in Inbox/Profile/Search tabs.
b12d7c1
@boscojwho
- Use navigation router in Settings.
2e8375b
@boscojwho
- Fix unused closure param.
665e981
@boscojwho
Merge branch 'boscojwho/enum-navigation-routes' into bosco/enum-navig…
847451d 
…ation-path

* boscojwho/enum-navigation-routes:
  - Fix unused closure param.
  - Use navigation router in Settings.
  - Use navigation router in Inbox/Profile/Search tabs.
  - Move NavigationContext to separate file.
  - Vary what value is passed to NavigationLink based on context.
  Use enum route to construct navigation path, where possible. Note: - Exception is in sidebar.
  - *WIP* Use NavigationRoute enum to configure navigation path.
  - Add `AnyNavigationPath` so view modifiers (or anything else) that need a reference to a navigation path can use whatever.
  - Add environment value for navigation routes.
  - Add navigation routes for non-settings paths.

# Conflicts:
#	Mlem/Views/Shared/Links/Community Link View.swift
#	Mlem/Views/Shared/Links/User/UserLinkView.swift
@boscojwho boscojwho requested a review from a team as a code owner September 15, 2023 08:34
@boscojwho boscojwho requested review from mormaer and ShadowJonathan and removed request for a team September 15, 2023 08:34
mormaer
mormaer approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@mormaer mormaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I've not had a chance to build and run it on device, so I'll assume it all works and you checked it 🙃

@mormaer
Copy link
Collaborator

mormaer commented Sep 15, 2023

I have a branch that restructures onboarding which has a OnboardingRoute enum in it, so I'll wait till this is in and rebase / make it match this pattern for consistency 👍

@boscojwho boscojwho merged commit a6bcc18 into dev Sep 15, 2023
2 of 3 checks passed
@boscojwho boscojwho deleted the bosco/enum-navigation-path branch September 15, 2023 23:09
@boscojwho boscojwho mentioned this pull request Sep 16, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mormaer mormaer mormaer approved these changes

@ShadowJonathan ShadowJonathan Awaiting requested review from ShadowJonathan ShadowJonathan is a code owner automatically assigned from mlemgroup/mlem-dev-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boscojwho @mormaer