Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update profile headers to be more readable #590

Merged
merged 6 commits into from
Sep 10, 2023
Merged

Update profile headers to be more readable #590

merged 6 commits into from
Sep 10, 2023

Conversation

JakeShirley
Copy link
Member

@JakeShirley JakeShirley commented Sep 10, 2023 •
edited
Loading

Checklist

  • I have read CONTRIBUTING.md
  • I have described what this PR contains
  • This PR addresses one or more open issues that were assigned to me:
    - n/a
  • If this PR alters the UI, I have attached pictures/videos

Pull Request Information

About this Pull Request

  • Updates default avatar to be person.fill instead of a grey circle.
  • Updates the labels in header to be .primary color instead of .white as that was basically unreadable if you had no banner or a light colored banner.
  • Added more previews and fixed one with a crash at preview time.

Screenshots and Videos

Screenshot 2023-09-10 at 9 22 42 AM Screenshot 2023-09-10 at 9 20 01 AM

Additional Context

n/a

@JakeShirley JakeShirley requested a review from a team as a code owner September 10, 2023 16:22
@JakeShirley JakeShirley requested review from ShadowJonathan and EricBAndrews and removed request for a team September 10, 2023 16:22
EricBAndrews
EricBAndrews approved these changes Sep 10, 2023
View reviewed changes
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JakeShirley JakeShirley merged commit ee83e22 into dev Sep 10, 2023
4 checks passed
@JakeShirley JakeShirley deleted the jake/profile_readability branch September 10, 2023 16:38
boscojwho pushed a commit to boscojwho/mlem that referenced this pull request Sep 16, 2023
@JakeShirley @boscojwho
Update profile headers to be more readable (mlemgroup#590)
74a1b48
boscojwho pushed a commit that referenced this pull request Oct 7, 2023
@JakeShirley @boscojwho
Update profile headers to be more readable (#590)
68f89a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricBAndrews EricBAndrews EricBAndrews approved these changes

@ShadowJonathan ShadowJonathan Awaiting requested review from ShadowJonathan ShadowJonathan is a code owner automatically assigned from mlemgroup/mlem-dev-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakeShirley @EricBAndrews