-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort Menu Changes #589
Sort Menu Changes #589
Conversation
Made some changes. Still more to come. Discussion on Slack here. I brought back the small picker, with limited sort options. What do people think about the format shown in the image? Should the "Top" options be collapsed as they are on Clicking "Show All" opens a full-screen sheet with all sort options available. This sheet also includes a "Filters" section, with the option to hide/show read posts, as well as a Still to do:
|
It's pretty much done now, I think. (If you're wondering why |
Closes #617 |
Replaced the sort mode popup. Addresses:
Why?
We were missing a couple of sort modes, and adding them to the existing menu makes it even more large and cumbersome than it already is. This is my attempt at a better system. Let me know what you think. Feedback on the design would be appreciated too - as discussed in Slack, this setup isn't very apple-like. Would different appearance/animations be better? Or a different system entirely?
Edit: Discussion happened. See here.
Details
0.18.1
).APISiteVersion
struct to store the Lemmy version number. If the user's instance is on too old of a version, the three new sort modes will be disabled. Previously, the user would have been able to select these but an error message would have been shown. Now, they can't select them. I've only implemented this check for the three newest sort modes; I haven't bothered with the older ones. Of course, most users are on up-to-date instances, but if new sort modes (or features in general) are added in future this system would be used to prevent the user from accessing them until their instance updates.Video
ss2.mov