fix - access accounts tracker via dependency #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mormaer
requested review from
JakeShirley and
EricBAndrews
and removed request for
a team
mormaer
force-pushed
the
fix-access_to_accounts_tracker
branch
from
feadf13 to
37dac98
Compare
JakeShirley
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- No issue, just noticed it and it'd crash if we ever access it 🙈
Pull Request Information
About this Pull Request
This (tiny) PR just updates the
DeleteAccountViewto access the accounts tracker via@Dependencyinstead of@EnvironmentObject. The change made in #554 means that there is no accounts tracker in the environment so attempting to access it this way will crash the app.This has snuck through as the work in #554 happened on
devbefore the delete account changes frommasterwere re-integrated the other day in #573.